Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update comparing-commits.md #35099

Closed
wants to merge 1 commit into from
Closed

Update comparing-commits.md #35099

wants to merge 1 commit into from

Conversation

fgnievinski
Copy link
Contributor

explain how to compare branches when browsing a branch

Why:

Closes:

What's being changed (if available, include any code snippets, screenshots, or gifs):

Check off the following:

  • I have reviewed my changes in staging, available via the View deployment link in this PR's timeline (this link will be available after opening the PR).

    • For content changes, you will also see an automatically generated comment with links directly to pages you've modified. The comment won't appear if your PR only edits files in the data directory.

  • For content changes, I have completed the self-review checklist.

@fgnievinski
Update comparing-commits.md
be2cf3b 
explain how to compare branches when browsing a branch
@github-actions github-actions bot added the triage Do not begin working on this issue until triaged by the team label Oct 29, 2024
@github-actions GitHub Actions
Copy link
Contributor

Automatically generated comment ℹ️

This comment is automatically generated and will be overwritten every time changes are committed to this branch.

The table contains an overview of files in the content directory that have been changed in this pull request. It's provided to make it easy to review your changes on the staging site. Please note that changes to the data directory will not show up in this table.

Content directory changes

You may find it useful to copy this table into the pull request summary. There you can edit it to share links to important articles or changes and to give a high-level overview of how the changes in your pull request support the overall goals of the pull request.

Source Preview Production What Changed
pull-requests/committing-changes-to-your-project/viewing-and-comparing-commits/comparing-commits.md fpt
ghec
ghes@ 3.14 3.13 3.12 3.11 3.10
fpt
ghec
ghes@ 3.14 3.13 3.12 3.11 3.10

fpt: Free, Pro, Team
ghec: GitHub Enterprise Cloud
ghes: GitHub Enterprise Server

@nguyenalex836 nguyenalex836 added content This issue or pull request belongs to the Docs Content team waiting for review Issue/PR is waiting for a writer's review pull requests Content related to pull requests and removed triage Do not begin working on this issue until triaged by the team labels Oct 29, 2024
@nguyenalex836
Copy link
Contributor

@fgnievinski Thanks so much for opening a PR! I'll get this triaged for review ✨

@nguyenalex836 nguyenalex836 added waiting for review Issue/PR is waiting for a writer's review and removed waiting for review Issue/PR is waiting for a writer's review labels Oct 29, 2024
subatoi
subatoi requested changes Oct 30, 2024
View reviewed changes
Copy link
Contributor

@subatoi subatoi left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi 👋

I'd be happy to accept this in principle, and I put up some recommended changes before editing this comment ... but in hindsight I'm afraid I think we need to change this whole section internally. There are considerations we need to make with notes about relevant access (write access) in order for certain flows to appear, and quite clearly the documentation is outdated and needs work.

Thank you for highlighting this but on this occasion I don't think it's appropriate to open this for contributors. I'll schedule this work internally, instead.

@subatoi subatoi closed this Oct 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@subatoi subatoi subatoi requested changes

Assignees
No one assigned
Labels
content This issue or pull request belongs to the Docs Content team pull requests Content related to pull requests waiting for review Issue/PR is waiting for a writer's review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fgnievinski @nguyenalex836 @subatoi